[Podcast Feed Reload] Add tooltip #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielebogo
requested review from
frosty,
adriana-elizondo and
SergioEstevao
and removed request for
frosty and
adriana-elizondo
danielebogo
commented
Feb 6, 2025
| } | ||
| } | ||
|
|
||
| struct TipViewStatic: View { |
There was a problem hiding this comment.
@SergioEstevao I extracted the body to a new View as I had many problems with the size returned by the geometry proxy. Using a static view and setting this sizingOptions = [.preferredContentSize] seems to work properly each time.
podcasts/PodcastViewController.swift
Outdated
| guard | ||
| Settings.shouldShowPodcastFeeReloadTip, | ||
| FeatureFlag.podcastFeedUpdate.enabled, | ||
| podcastFeedReloadTooltip != nil |
There was a problem hiding this comment.
I believe this need to be changed to == nil
There was a problem hiding this comment.
Fixed in effef97
SergioEstevao
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the tooltip to advise the user of the feed reload functionality.
To test
Profile -> Cog icon at top right -> Beta Features🔵 Tracked: podcast_refresh_episode_tooltip_shown🔵 Tracked: podcast_refresh_episode_tooltip_dismissedChecklist
CHANGELOG.mdif necessary.